Re: [PATCH][PROPOSAL] Add enum releation option type
От | Tom Lane |
---|---|
Тема | Re: [PATCH][PROPOSAL] Add enum releation option type |
Дата | |
Msg-id | 8871.1541085014@sss.pgh.pa.us обсуждение исходный текст |
Ответ на | Re: [PATCH][PROPOSAL] Add enum releation option type (Robert Haas <robertmhaas@gmail.com>) |
Ответы |
Re: [PATCH][PROPOSAL] Add enum releation option type
|
Список | pgsql-hackers |
Robert Haas <robertmhaas@gmail.com> writes: > On Wed, Mar 7, 2018 at 10:23 AM Nikolay Shaplov <dhyan@nataraj.su> wrote: >>> I see you lost the Oxford comma: >>> >>> -DETAIL: Valid values are "on", "off", and "auto". >>> +DETAIL: Valid values are "auto", "on" and "off". >>> >>> Please put these back. >> Actually that's me who have lost it. The code with oxford comma would be a >> bit more complicated. We should put such coma when we have 3+ items and do not >> put it when we have 2. >> >> Does it worth it? > In my opinion, it is worth it. Uh ... I've not been paying attention to this thread, but this exchange seems to be about somebody constructing a message like that piece-by-piece in code. This has got to be a complete failure from the translatability standpoint. See https://www.postgresql.org/docs/devel/static/nls-programmer.html#NLS-GUIDELINES regards, tom lane
В списке pgsql-hackers по дате отправления: