Re: zstd compression for pg_dump
| От | Euler Taveira |
|---|---|
| Тема | Re: zstd compression for pg_dump |
| Дата | |
| Msg-id | 8851e7ad-a1ff-4827-9805-9ba73b289e7f@app.fastmail.com обсуждение исходный текст |
| Ответ на | Re: zstd compression for pg_dump (Tomas Vondra <tomas.vondra@enterprisedb.com>) |
| Список | pgsql-hackers |
On Sat, Feb 25, 2023, at 7:31 AM, Tomas Vondra wrote:
On 2/24/23 20:18, Justin Pryzby wrote:> This is a draft patch - review is welcome and would help to get this> ready to be considererd for v16, if desired.>> I'm going to add this thread to the old CF entry.>Thanks. Sadly cfbot is unhappy - the windows and cplusplus builds failedbecause of some issue in pg_backup_archiver.h. But it's a bit bizarrebecause the patch does not modify that file at all ...
cpluspluscheck says
# pg_dump is not C++-clean because it uses "public" and "namespace"
# as field names, which is unfortunate but we won't change it now.
Hence, the patch should exclude the new header file from it.
--- a/src/tools/pginclude/cpluspluscheck
+++ b/src/tools/pginclude/cpluspluscheck
@@ -153,6 +153,7 @@ do
test "$f" = src/bin/pg_dump/compress_gzip.h && continue
test "$f" = src/bin/pg_dump/compress_io.h && continue
test "$f" = src/bin/pg_dump/compress_lz4.h && continue
+ test "$f" = src/bin/pg_dump/compress_zstd.h && continue
test "$f" = src/bin/pg_dump/compress_none.h && continue
test "$f" = src/bin/pg_dump/parallel.h && continue
test "$f" = src/bin/pg_dump/pg_backup_archiver.h && continue
В списке pgsql-hackers по дате отправления: