Re: B-Tree support function number 3 (strxfrm() optimization)

>>>>> "Robert" == Robert Haas <robertmhaas@gmail.com> writes:
Robert> All right, it seems Tom is with you on that point, so afterRobert> some study, I've committed this with very
minormodifications.
 

While hacking up a patch to demonstrate the simplicity of extending this
to the Datum sorter, I seem to have run into a fairly major issue with
this: there seems to be no attempt whatsoever to handle spilling to disk
correctly. The data spilled to disk only has the un-abbreviated values,
but nothing tries to re-abbreviate it (or disable abbreviations) when it
is read back in, and chaos ensues:

set work_mem = 64;
select v, v > lag(v) over (order by v) from (select 'B'||i as v from generate_series(1,10000) i       union all select
'a'||ifrom generate_series(1,10000) i offset 0) s order by v limit 20;
 
  v    | ?column? 
--------+----------a10000 | B10000 | fa1000  | ta1001  | ta1002  | ta1003  | tB1000  | fB1001  | tB1002  | tB1003  |
tB1004 | tB1005  | ta1004  | ta1005  | ta1006  | ta1007  | ta1008  | tB1     | fB10    | tB100   | t
 
(20 rows)

-- 
Andrew (irc:RhodiumToad)