Re: Question regarding the database page layout.

Tom Lane <tgl@sss.pgh.pa.us> writes:

> Gregory Stark <stark@enterprisedb.com> writes:
>> Tom Lane <tgl@sss.pgh.pa.us> writes:
>>> BTW, there are at least two copies of that code to be changed.  I'd
>>> suggest grepping for assignments to t_hoff to be sure there aren't more.
>
>> I did send in a patch a while ago to get rid of the old HeapFormTuple() and
>> friends.
>
> I remember discussing that idea, but I don't recall seeing an actual
> patch?  It would have to be quite large because of the number of places
> using the old way.  I'd also be a bit worried about breaking add-on
> modules to little purpose ...

Huh, apparently I did it but didn't actually send in the patch:

http://archives.postgresql.org/pgsql-hackers/2007-10/msg00851.php

I looked around and I don't seem to have it lying around any more. (Kind of
mystifying since I have tons of old source trees and patches, just not that
one.)

I could do the janitorial work again if we're interested.

--  Gregory Stark EnterpriseDB          http://www.enterprisedb.com Ask me about EnterpriseDB's On-Demand Production
Tuning