Re: latest hstore patch

>>>>> "David" == "David E Wheeler" <david@kineticode.com> writes:
David> Just a few thoughts for discussion:
David> * From my previous posts: Is it time to kill off `@` and `~`,?David> Not necessarily for your patch to handle,
justwondering whatDavid> others think.
 

I'll take them out if people think that is appropriate.
David> * I like the %% operator for converting to arrays. Though IDavid> think maybe I would have liked %@ better, but
maybethat'sDavid> just the Perl hacker in me.
 

I originally tried just % but something in the grammar stops you using
that for a unary op.
David> * I also like the new %# operator to convert toDavid> two-dimensional arrays. But if you adopted %@ for
arrays,David>maybe %@@ better indicates a 2-dimensional array? I'm justDavid> thinking out lout here, I'm happy to have
themno matter whatDavid> they're called.
 

%@@ is a bit on the ugly side for an operator I think.
David> * More name stuff: Why `hstore_to_list` rather thanDavid> `hstore_to_array`?  And I'm not sure about
`hstore_to_matrix`David>for the 2-dimensional array.  I guess that's better thanDavid>
`hstore_to_multidimensional_array`would be. ;-)
 

I intentionally avoided hstore_to_array because it would be unclear
which one it meant (the 1-d or 2-d result).

-- 
Andrew (irc:RhodiumToad)