Re: refactoring basebackup.c (zstd workers)

Robert Haas <robertmhaas@gmail.com> writes:

> On Mon, Mar 21, 2022 at 2:22 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
>> + * during parsing, and will otherwise contain a an appropriate error message.
>
> OK, thanks. v4 attached.

I haven't read the whole patch, but I noticed an omission in the
documentation changes:

> diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
> index 9178c779ba..00c593f1af 100644
> --- a/doc/src/sgml/protocol.sgml
> +++ b/doc/src/sgml/protocol.sgml
> @@ -2731,14 +2731,24 @@ The commands accepted in replication mode are:
>         <varlistentry>
> -        <term><literal>COMPRESSION_LEVEL</literal> <replaceable>level</replaceable></term>
> +        <term><literal>COMPRESSION_DETAIL</literal> <replaceable>detail</replaceable></term>
>          <listitem>
>           <para>
>            Specifies the compression level to be used.

This is no longer the accurate. How about something like like "Specifies
details of the chosen compression method"?

- ilmari