Re: question about new fmgr in 7.1 snapshots

Jan Wieck <janwieck@Yahoo.com> writes:
> Tom Lane wrote:
>> Jeff Hoffmann <jeff@propertykey.com> writes:
>>>> my question is whether i should change the function to use the new fmgr
>>>> type of definition or if it's only for internal functions.
>> 
>> Up to you.  If you need any of the new features (like clean handling
>> of NULLs) then convert.  If you were happy with the old way, no need.

>     Are  you  sure  on  that?  Doesn't  TOAST  mean that any user
>     defined function  recieving  variable  size  attributes  must
>     expect  them  now  to  be  compressed  or stored external and
>     change it's access to them going through the  untoasting?

If you have a user-defined function that takes a potentially-toasted
argument, you'll have to fix it to detoast its argument.  I don't
think it's appropriate to saddle fmgr with that responsibility.

At least in theory, you could detoast the argument without also buying
into the new fmgr notation, but I agree that converting is easier ;-)
        regards, tom lane