perlcritic script

Here's a small patch to add a script to call perlcritic, in the same way
that we have a script to call perltidy. Is also includes a perlcriticrc
file containing a policy to allow octal constants with leading zeros.
That's the only core severity 5 policy we are currently no in compliance
with.


We should probably look at being rather more aggressive with perlcritic.
I've made the buildfarm client code compliant with some exceptions down
to severity level 3. Here are the profile exceptions:

    [-Variables::RequireLocalizedPunctuationVars]
    [TestingAndDebugging::ProhibitNoWarnings]
    allow = once
    [-InputOutput::RequireBriefOpen]
    [-Subroutines::RequireArgUnpacking]
    [-RegularExpressions::RequireExtendedFormatting]
    [-Variables::ProhibitPackageVars]
    [-ErrorHandling::RequireCarping]
    [-ValuesAndExpressions::ProhibitComplexVersion]
    [InputOutput::ProhibitBacktickOperators]
    only_in_void_context = 1
    [-Modules::ProhibitExcessMainComplexity]
    [-Subroutines::ProhibitExcessComplexity]
    [-ValuesAndExpressions::ProhibitImplicitNewlines]
    [-ControlStructures::ProhibitCascadingIfElse]
    [-ControlStructures::ProhibitNegativeExpressionsInUnlessAndUntilConditions]
    [-ErrorHandling::RequireCheckingReturnValueOfEval ]
    [-BuiltinFunctions::ProhibitComplexMappings]

There are also 21 places in the code with "no critic" markings at
severity 3 and above.


cheers


andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services