Re: Linux LSB init script
От | Wolfgang Wilhelm |
---|---|
Тема | Re: Linux LSB init script |
Дата | |
Msg-id | 854062.48757.qm@web23208.mail.ird.yahoo.com обсуждение исходный текст |
Ответ на | Re: Linux LSB init script ("Kevin Grittner" <Kevin.Grittner@wicourts.gov>) |
Ответы |
Re: Linux LSB init script
|
Список | pgsql-hackers |
Hello Kevin,
a technical comment about line 71 and following of your shell script:
# Check that we have one parameter: action
if [ $# -ne 1 ] ; then
if [ $# -lt 1 -o "$1" = "" ] ] ; then
log_failure_msg "$0: action not specified"
else
log_failure_msg "$0: too many parameters"
fi
log_warning_msg "$usage"
exit 2
fi
action="$1"
a technical comment about line 71 and following of your shell script:
# Check that we have one parameter: action
if [ $# -ne 1 ] ; then
if [ $# -lt 1 -o "$1" = "" ] ] ; then
log_failure_msg "$0: action not specified"
else
log_failure_msg "$0: too many parameters"
fi
log_warning_msg "$usage"
exit 2
fi
action="$1"
I think in the second "if" there's a closing square bracket too much.
Wolfgang
Von: Kevin Grittner <Kevin.Grittner@wicourts.gov>
An: Andrew Dunstan <andrew@dunslane.net>
CC: David Fetter <david@fetter.org>; Greg Stark <gsstark@mit.edu>; pgsql-hackers@postgresql.org
Gesendet: Montag, den 31. August 2009, 21:06:22 Uhr
Betreff: Re: [HACKERS] Linux LSB init script
Andrew Dunstan <andrew@dunslane.net> wrote:
> cvsutils
That allowed me to use 'cvsdo add' and 'cvs diff -cN' to generate the
attached. This contains a couple minor fixes to what I posted in "new
file" form. I was holding off on the CommitFest entry until I sorted
out the format; I'll link here as version 1 of the patch.
-Kevin
Wolfgang
Von: Kevin Grittner <Kevin.Grittner@wicourts.gov>
An: Andrew Dunstan <andrew@dunslane.net>
CC: David Fetter <david@fetter.org>; Greg Stark <gsstark@mit.edu>; pgsql-hackers@postgresql.org
Gesendet: Montag, den 31. August 2009, 21:06:22 Uhr
Betreff: Re: [HACKERS] Linux LSB init script
Andrew Dunstan <andrew@dunslane.net> wrote:
> cvsutils
That allowed me to use 'cvsdo add' and 'cvs diff -cN' to generate the
attached. This contains a couple minor fixes to what I posted in "new
file" form. I was holding off on the CommitFest entry until I sorted
out the format; I'll link here as version 1 of the patch.
-Kevin
Вложения
В списке pgsql-hackers по дате отправления: