Re: jdbc1.AbstractJdbc1Statement.setBinaryStream bug and

Kris Jurka <books@ejurka.com> writes:

> On Wed, 7 Jan 2004, Martin Holz wrote:
>
> > Hello,
> >
> > org.postgresql.jdbc1.AbstractJdbc1Statement.setBinaryStream()
> > in postgresql 7.4.1 wrongly assumes, that
> > java.io.InputStream.read(byte[] b,int offset,int len )
> > will always read len bytes. InputStream only guarantees to
> > return at least 1 byte per call. The attached patch solves the bug.
> >
>
> I have applied a version of this patch to the cvs version on gborg.  The
> setAsciiStream and setUnicodeStream methods also had this problem.

Thank you. Why does it not show up at

http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/interfaces/jdbc/org/postgresql/jdbc1/AbstractJdbc1Statement.java
?

>  Your
> patch was not quite right because it didn't correctly handle the situation
> where the Stream was longer than the given length.
>
You are right.