Re: PATCH: Unlogged tables re-initialization tests
От | David Steele |
---|---|
Тема | Re: PATCH: Unlogged tables re-initialization tests |
Дата | |
Msg-id | 8325689c-9b56-e489-b6f9-c6bf5822cbc9@pgmasters.net обсуждение исходный текст |
Ответ на | Re: PATCH: Unlogged tables re-initialization tests (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>) |
Ответы |
Re: PATCH: Unlogged tables re-initialization tests
|
Список | pgsql-hackers |
On 3/12/18 11:27 AM, Peter Eisentraut wrote: > On 3/11/18 05:11, Michael Paquier wrote: >> On Fri, Mar 09, 2018 at 05:23:48PM -0500, Peter Eisentraut wrote: >>> This seems like a useful test. >>> >>> On 3/5/18 12:35, David Steele wrote: >>>> +mkdir($tablespaceDir) >>>> + or die "unable to mkdir \"$tablespaceDir\""; >>> >>> Use BAIL_OUT instead of die in tests. >> >> Would it be better to make this practice more uniform? From the code of >> the tests: >> $ git grep die -- */t/*.pl | wc -l >> 50 > > Yes, or maybe there is a way to "catch" die and turn it into BAIL_OUT? something like this should work: # Convert die to BAIL_OUT $SIG{__DIE__} = sub {BAIL_OUT(@_)}; -- -David david@pgmasters.net
В списке pgsql-hackers по дате отправления: