Re: notice about costly ri checks (2)

Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Tom Lane wrote:
>> I'd suggest something along the lines of
>>
>> NOTICE: foreign key constraint "constrname" will require a cross-type conversion
>> DETAIL: key columns "fkcol" and "pkcol" are of different types integer and double precision

> I suggested the constraint name because of multi-column keys, where he
> would have to print an arbitrary number of columns in the message.  It
> didn't seem worth doing that work.  I see your idea of just printing the
> column, but that doesn't really point to the primary/foreign key
> relationship.  If the user can't figure out which columns are a mismatch
> from the constraint name, they have larger problems than this.  :-)

Why should we make them guess which column is the problem, when we know
it perfectly well?

>> If you want it to be a WARNING then we gotta work on the text some more.

> Yes, let's re-add 'costly' to the text:

> WARNING: foreign key constraint "constrname" will require a costly cross-type conversion

Works for me, but I still want the DETAIL ...

            regards, tom lane