Re: to_date_valid()

On 15.08.2016 10:24, Artur Zakirov wrote:
> On 14.08.2016 01:52, Andreas 'ads' Scherbaum wrote:
>>
>> Attached is a patch to "do the right thing". The verification is in
>> "to_date()" now, the extra function is removed. Regression tests are
>> updated - two or three of them returned a wrong date before, and still
>> passed. They fail now. Documentation is also updated.
>>
>>
>> Regards,
>>
>
> Is it right and "true" way to validate date by extra transforming and
> comparison?
>
> Maybe validate date by using ValidateDate(). Attached sample patch.

This does not solve the problem at hand, and let's wrong dates/formats 
slip through:

./buildclient.py -v -c demo-config-pg.yaml --run-configure --run-make 
--run-install --no-clean-at-all --patch 
'https://www.postgresql.org/message-id/95738e12-6ed6-daf5-9dcf-6336072e6b15%40postgrespro.ru'


postgres=# SELECT to_date('2011 12  18', 'YYYY MM   DD');  to_date
------------ 2011-12-08
(1 row)


That is from the regression tests, and obviously handles the date 
transformation wrong. My attempt catches this, because I compare the 
date with the input date, and do not rely on a valid date only.

--             Andreas 'ads' Scherbaum
German PostgreSQL User Group
European PostgreSQL User Group - Board of Directors
Volunteer Regional Contact, Germany - PostgreSQL Project