Re: patch for cleanup protocol

Ludek Finstrle <luf@pzkagis.cz> writes:

> Hello,
>
>   protocol option is no longer used with libpq driver version.
> So I clean up the code. I try change both languages (English and Japanese).
> I didn't sure how to clean up faq.html so I don't do it.
>
> Please review and comment

I'm not qualified to tell if the changes are correct, but I just
noticed this one thing:

> diff -c psqlodbc.orig\dlg_specific.c psqlodbc.full\dlg_specific.c
> *** psqlodbc.orig\dlg_specific.c    Wed Nov 30 13:44:16 2005
> --- psqlodbc.full\dlg_specific.c    Mon Dec 19 23:33:09 2005
> ***************
> *** 65,72 ****
>
";%s=%s;%s=%s;%s=%s;%s=%s;%s=%s;%s=%s;%s=%s;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%s;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d",
>                   INI_READONLY,
>                   ci->onlyread,
> -                 INI_PROTOCOL,
> -                 ci->protocol,
>                   INI_FAKEOIDINDEX,
>                   ci->fake_oid_index,
>                   INI_SHOWOIDCOLUMN,
> --- 65,70 ----

If you remove these arguments, you have to remove the corresponding
(second from start) "%s=%s" pair from the format string, otherwise
it'll use the wrong variables for the %d's further on.


Tomas