Re: meson: Specify -Wformat as a common warning flag for extensions
От | Peter Eisentraut |
---|---|
Тема | Re: meson: Specify -Wformat as a common warning flag for extensions |
Дата | |
Msg-id | 7f5f3c2c-b61b-4064-b551-aac57d95c879@eisentraut.org обсуждение исходный текст |
Ответ на | Re: meson: Specify -Wformat as a common warning flag for extensions (Sutou Kouhei <kou@clear-code.com>) |
Список | pgsql-hackers |
On 29.05.24 08:47, Sutou Kouhei wrote: > In <4707d4ed-f268-43c0-b4dd-cdbc7520f508@eisentraut.org> > "Re: meson: Specify -Wformat as a common warning flag for extensions" on Tue, 28 May 2024 23:31:05 -0700, > Peter Eisentraut <peter@eisentraut.org> wrote: > >> On 07.04.24 18:01, Sutou Kouhei wrote: >>> +# We don't have "warning_level == 3" and "warning_level == >>> +# 'everything'" here because we don't use these warning levels. >>> +if warning_level == '1' >>> + common_builtin_flags += ['-Wall'] >>> +elif warning_level == '2' >>> + common_builtin_flags += ['-Wall', '-Wextra'] >>> +endif >> >> I would trim this even further and always export just '-Wall'. The >> other options aren't really something we support. > > OK. How about the v6 patch? It always uses '-Wall'. Yes, this looks good to me. All: I think we should backpatch this. Otherwise, meson-based installs will get suboptimal behavior for extension builds via pgxs.
В списке pgsql-hackers по дате отправления: