Re: logical replication launcher crash on buildfarm

On 01/04/17 03:44, Andres Freund wrote:
> On 2017-04-01 03:26:01 +0200, Petr Jelinek wrote:
>> On 01/04/17 02:53, Robert Haas wrote:
>>> On Fri, Mar 31, 2017 at 8:32 PM, Petr Jelinek
>>> <petr.jelinek@2ndquadrant.com> wrote:
>>>> Right, changed to BGW_MAXLEN.
>>>
>>> Hmm, I don't know if there's any good reason not to just use strcmp(),
>>> but sure, OK.  Committed and back-patched.
> 
> Cool!
> 
> 
>> Hmm culicidae still fails, this time only in parallel worker code.
>> This  didn't happen on my machine which is strange.
> 
> Interesting.  Did you reproduce the failure before?  I wonder if the
> issue is that you don't build a position independent executable?
> 

I did reproduce the original issue yes, that's how I tested the patch. I
just copy pasted CFLAGS from the buildfarm configuration of culicidae TBH.

--  Petr Jelinek                  http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training &
Services