Re: pgbench - test whether a variable exists

On 20.10.2020 15:22, Ibrar Ahmed wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world:  not tested
> Implements feature:       not tested
> Spec compliant:           tested, failed
> Documentation:            not tested
>
> I am not very convinced to have that, but I have performed some testing on master ().
>
> I found a crash
>
> [Thread debugging using libthread_db enabled]
> Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
> Core was generated by `pgbench postgres -T 60 -f a.sql'.
> Program terminated with signal SIGSEGV, Segmentation fault.
> #0  0x000055bfb572a4b2 in expr_yylex (yylval_param=0x7fff29a60870, yyscanner=0x55bfb6867a90) at exprscan.c:1107
> 1107            *yy_cp = yyg->yy_hold_char;
> (gdb) bt
> #0  0x000055bfb572a4b2 in expr_yylex (yylval_param=0x7fff29a60870, yyscanner=0x55bfb6867a90) at exprscan.c:1107
> #1  0x000055bfb572cb63 in expr_lex_one_word (state=0x55bfb6867a10, word_buf=0x7fff29a608d0, offset=0x7fff29a608a8) at
exprscan.l:340
> #2  0x000055bfb57358fd in process_backslash_command (sstate=0x55bfb6867a10, source=0x55bfb68653a0 "a.sql") at
pgbench.c:4540
> #3  0x000055bfb5736528 in ParseScript (
>      script=0x55bfb68655f0 "\\set nbranches :scale\n\\set ntellers 10 * :scale\n\\set naccounts 100000 *
:scale\n\\setrandomaid 1 :naccounts\n\\setrandom bid 1 :nbranches\n\\setrandom tid 1 :ntellers\n\\setrandom delta -5000
5000\nBEGIN;\nUPD"...,desc=0x55bfb68653a0 "a.sql", weight=1) at pgbench.c:4826
 
> #4  0x000055bfb5736967 in process_file (filename=0x55bfb68653a0 "a.sql", weight=1) at pgbench.c:4962
> #5  0x000055bfb5738628 in main (argc=6, argv=0x7fff29a610d8) at pgbench.c:5641
>
> The new status of this patch is: Waiting on Author

This patch was inactive during the commitfest, so I am going to mark it 
as "Returned with Feedback".
Fabien, are you planning to continue working on it?

-- 
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company