On 03/28/2018 08:55 PM, David Steele wrote:
> On 3/4/18 11:17 AM, Tomas Vondra wrote:
>>
>> Furthermore, the patch is yet another victim of fd1a421fe - fixing the
>> pg_proc entries is trivial, but a new version is needed.
>>
>> I'd also like to see an example/explanation how this improves this
>> situation compared to only having pg_postmaster_start_time.
>>
>> So I'm setting this as waiting on author for now.
>
> I'm not sure why this was set back to Needs Review since it neither
> applies cleanly nor builds.
>
It likely applied/built fine when it was set to NR, but got broken by
some recent commit.
> I'm setting this entry to Waiting on Author, but based on the discussion
> I think it should be Returned with Feedback.
>
Fine with me.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services