Re: pgsql: Fix potential NULL pointer dereference in getIdentitySequence()

On 2024-05-26 Su 07:58, Michael Paquier wrote:
> Fix potential NULL pointer dereference in getIdentitySequence()
>
> The function invokes SearchSysCacheAttNum() and SearchSysCacheAttName().
> They may respectively return 0 for the attribute number or NULL for
> the attribute name if the attribute does not exist, without any kind of
> error handling.  The common practice is to check that the data retrieved
> from the syscache is valid.  There is no risk of NULL pointer
> dereferences currently, but let's stick to the practice of making sure
> that this data is always valid, to catch future inconsistency mistakes.
> The code is switched to use get_attnum() and get_attname(), and adds
> some error handling.
>
> Oversight in 509199587df7.
>
> Reported-by: Ranier Vilela
> Author: Ashutosh Bapat
> Discussion: https://postgr.es/m/CAEudQAqh_RZqoFcYKso5d9VhF-Vd64_ZodfQ_2zSusszkEmyRg@mail.gmail.com
>

This appears to have upset a number of buildfarm members


cheers


andrew

-- 

Andrew Dunstan
EDB: https://www.enterprisedb.com