Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit

On 2021/01/26 16:39, Fujii Masao wrote:
> 
> 
> On 2021/01/26 16:33, Bharath Rupireddy wrote:
>> On Tue, Jan 26, 2021 at 12:54 PM Fujii Masao
>> <masao.fujii@oss.nttdata.com> wrote:
>>> On 2021/01/26 16:05, Tom Lane wrote:
>>>> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
>>>>> Thanks for the review! I fixed them and pushed the patch!
>>>>
>>>> Buildfarm is very not happy ...
>>>
>>> Yes.... I'm investigating that.
>>>
>>>    -- Return false as connections are still in use, warnings are issued.
>>>    SELECT postgres_fdw_disconnect_all();
>>> -WARNING:  cannot close dropped server connection because it is still in use
>>> -WARNING:  cannot close connection for server "loopback" because it is still in use
>>>    WARNING:  cannot close connection for server "loopback2" because it is still in use
>>> +WARNING:  cannot close connection for server "loopback" because it is still in use
>>> +WARNING:  cannot close dropped server connection because it is still in use
>>>
>>> The cause of the regression test failure is that the order of warning messages
>>> is not stable. So I'm thinking to set client_min_messages to ERROR temporarily
>>> when doing the above test.
>>
>> Looks like we do suppress warnings/notices by setting
>> client_min_messages to ERROR/WARNING. For instance, "suppress warning
>> that depends on wal_level" and  "Suppress NOTICE messages when
>> users/groups don't exist".
> 
> Yes, so I pushed that change to stabilize the regression test.
> Let's keep checking how the results of buildfarm members are changed.

+WARNING:  roles created by regression test cases should have names starting with "regress_"
  CREATE ROLE multi_conn_user2 SUPERUSER;
+WARNING:  roles created by regression test cases should have names starting with "regress_"

Hmm... another failure happened.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION