Re: Incorrect comment regarding command completion tags
От | Mark Dilger |
---|---|
Тема | Re: Incorrect comment regarding command completion tags |
Дата | |
Msg-id | 72527BF7-9F54-4DA5-9B25-515D290C569B@enterprisedb.com обсуждение исходный текст |
Ответ на | Incorrect comment regarding command completion tags (David Rowley <dgrowleyml@gmail.com>) |
Ответы |
Re: Incorrect comment regarding command completion tags
|
Список | pgsql-hackers |
> On Oct 13, 2022, at 2:56 PM, David Rowley <dgrowleyml@gmail.com> wrote: > > I was looking at the code in EndCommand() and noticed a comment > talking about some Asserts which didn't seem to exist in the code. > The comment also talks about LastOid which looks like the name of a > variable that's nowhere to be seen. > > It looks like the Asserts did exists when the completion tag patch was > being developed [1] but they disappeared somewhere along the line and > the comment didn't get an update before 2f9661311 went in. > > In the attached, I rewrote the comment to remove mention of the > Asserts. I also tried to form the comment in a way that's more > understandable about why we always write a "0" in "INSERT 0 <nrows>". Your wording is better. +1 — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
В списке pgsql-hackers по дате отправления: