Re: Add Nullif case for eval_const_expressions_mutator

Поиск
Список
Период
Сортировка
От Peter Eisentraut
Тема Re: Add Nullif case for eval_const_expressions_mutator
Дата
Msg-id 6fceea45-8ce5-db49-d490-285a991b84a9@enterprisedb.com
обсуждение исходный текст
Ответ на RE: Add Nullif case for eval_const_expressions_mutator  ("houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>)
Ответы Re: Add Nullif case for eval_const_expressions_mutator  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Список pgsql-hackers
On 24.03.21 11:52, houzj.fnst@fujitsu.com wrote:
>> +                if (!has_nonconst_input)
>> +                    return ece_evaluate_expr(expr);
>>
>> That's not okay without a further check to see if the comparison function used
>> by the node is immutable.  Compare ScalarArrayOpExpr, for instance.
> 
> Thanks for pointing it out.
> Attaching new patch with this change.

This patch looks okay to me and addresses all the feedback that was  
given.  If there are no more comments, I'll commit it in a few days.



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Amit Kapila
Дата:
Сообщение: Re: Use consistent terminology for tablesync slots.
Следующее
От: "Joel Jacobson"
Дата:
Сообщение: Re: Idea: Avoid JOINs by using path expressions to follow FKs