Re: BUG #14952: COPY fails to fill in IDENTITY column default value

On 12/30/17 18:26, Michael Paquier wrote:
> A RangeVar is used for the proposed patch 0002. Still does it matter? In
> the scenario proposed here, which is to fix ALTER TABLE ADD COLUMN
> GENERATED, then the sequence gets created and visible only once the
> transaction adding the column has been created.
> 
>      char        identity;        /* attidentity setting */
> +    RangeVar   *identitySequence;
>      CollateClause *collClause;    /* untransformed COLLATE spec, if any */
> It mat be better to tell that this is used to create a sequence in the
> same transaction as the one doing the parsing.

I would like to get this into next week's minor release as a bug fix.
Other than tweaking some of the comments, is there any more feedback on
this?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services