Re: APC/socket fix (final?)

Поиск
Список
Период
Сортировка
От Magnus Hagander
Тема Re: APC/socket fix (final?)
Дата
Msg-id 6BCB9D8A16AC4241919521715F4D8BCE171627@algol.sollentuna.se
обсуждение исходный текст
Ответ на APC/socket fix (final?)  (Claudio Natoli <claudio.natoli@memetrics.com>)
Ответы Re: APC/socket fix (final?)  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-patches
>> Hopeless, or cute, work-around?
>
>It's possibly workable in the limited context of the postmaster, but
>I've got doubts about doing it in libpq where we can't assume we know
>what the surrounding application will do.

No need to touch the frontend parts at all. Our APCs are server side
only, so it's not a problem there.

It should be just as with the kill defrine in win32.h - "#ifndef
FRONTEND".


To the other point - yes, it's a cute workaround. I'm a bit afraid that
we'll end up with another surprise down the road though, since the
behaviour of the select() function is known to be undefined in this
situation (or at leas tthe return value of it is). I'm not sure we can
rely on the pattern we're seeing now. We also don't know for sure about
send() and recv() (though I'm working on that).

I'm almost done with the "our own select()/recv()/send() functions"
attempt. I feel that's a more correct solution (not just a workaround),
*if* I can get the code good enough that we feel comfortable with it. If
not, then a workaround seems the way to go, and then Claudios one looks
good (except we might need to go with a global variable instead - but
the general way, and the localization of it looks good)


//Magnus

В списке pgsql-patches по дате отправления:

Предыдущее
От: Bruce Momjian
Дата:
Сообщение: Re: installdir patch for win32
Следующее
От: Tom Lane
Дата:
Сообщение: Re: APC/socket fix (final?)