Re: pg_dump crashes trying to dump database containing index on oid

Adam Haberlach <adam@newsnipple.com> writes:
> On Tue, May 23, 2000 at 01:27:28AM -0400, Tom Lane wrote:
>> Adam Haberlach <adam@newsnipple.com> writes:
>>>> pg_dump crashes trying to dump database containing index on oid
>>
>> You're a day too late to be the first reporter of this bug ;-).
>> See patch on pgpatches (yup, it's the obvious fix).

>     Hmm--I didn't seem to get that one (and I've been subscribed
> to pgsql-patches for nearly a month).

Now that you mention it, my mail log shows that it came back to me
via -hackers, but *not* via -patches.  The outgoing copy is appended.

Marc, I think the evidence is indisputable that majordomo has been
dropping some traffic for the past few days ... this makes at least
four separate reports ...

            regards, tom lane


To: pgsql-hackers@postgreSQL.org, pgsql-patches@postgresql.org
Subject: Sigh: 7.0 pg_dump fails if user table has index on OID
Date: Fri, 19 May 2000 19:16:40 -0400
Message-ID: <10300.958778200@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>

If any user-created index is on a system column (eg, OID),
7.0 pg_dump fails with "parseNumericArray: bogus number".

Mea culpa, mea maxima culpa --- some well-intentioned error checking
code was a bit too tight.  (But how'd this get through beta with no
one noticing?  It's been broken since January...)

The attached patch is committed for 7.0.1, but you will need to apply
it by hand if you have such indexes and you want to make a dump before
7.0.1 comes out.  (Alternatively, drop the indexes and remake them
by hand later.)

Thanks to Kyle Bateman for the bug report.

            regards, tom lane

*** src/bin/pg_dump/common.c.orig    Wed Apr 12 13:16:14 2000
--- src/bin/pg_dump/common.c    Fri May 19 19:00:00 2000
***************
*** 190,196 ****
          }
          else
          {
!             if (!isdigit(s) || j >= sizeof(temp) - 1)
              {
                  fprintf(stderr, "parseNumericArray: bogus number\n");
                  exit(2);
--- 190,196 ----
          }
          else
          {
!             if (!(isdigit(s) || s == '-') || j >= sizeof(temp) - 1)
              {
                  fprintf(stderr, "parseNumericArray: bogus number\n");
                  exit(2);