On Wed, Jan 31, 2024, at 11:09 PM, Hayato Kuroda (Fujitsu) wrote:
>
Why? Are you suggesting that the dry run mode covers just the verification
part? If so, it is not a dry run mode. I would expect it to run until the end
(or until it accomplish its goal) but *does not* modify data. For pg_resetwal,
the modification is one of the last steps and the other ones (KillFoo
functions) that are skipped modify data. It ends the dry run mode when it
accomplish its goal (obtain the new control data values). If we stop earlier,
some of the additional steps won't be covered by the dry run mode and a failure
can happen but could be detected if you run a few more steps.
>
Yes, it was my expectation. I'm still not sure which operations can detect by the
dry_run, but we can keep it for now.
The main goal is to have information for troubleshooting.
Good point. I included a check for pg_create_subscription role and CREATE
privilege on the specified database.
>
Not sure, but can we do the replication origin functions by these privilege?
According to the doc[1], these ones seem not to be related.
Hmm. No. :( Better add this check too.