Re: [PATCH] Correct RangeTblEntry.join_using_alias comment to reflect field order

Поиск
Список
Период
Сортировка
От Chao Li
Тема Re: [PATCH] Correct RangeTblEntry.join_using_alias comment to reflect field order
Дата
Msg-id 6761DC8A-6B7E-4B7F-95A4-E7CD32E2C2A8@gmail.com
обсуждение исходный текст
Ответ на [PATCH] Correct RangeTblEntry.join_using_alias comment to reflect field order  (Steve Lau <stevelauc@outlook.com>)
Список pgsql-hackers


On Sep 21, 2025, at 22:48, Steve Lau <stevelauc@outlook.com> wrote:

Hi hackers! 

Found a tiny incorrect comment of RangeTblEntry, field "alias" is actually above "join_using_alias", so the code comment could be updated to reflect the current field order:

> join_using_alias is an alias clause attached directly to JOIN/USING. It is different from the alias field (below) in that it does not hide the

Regards,
steve
 
<v1-0001-Correct-RangeTblEntry.join_using_alias-comment-to-re.patch>

“alias” is the second field of structure RangeTblEntry, so it should be above “join_using_alias”.

The change looks good to me.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/




В списке pgsql-hackers по дате отправления: