Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options

Поиск
Список
Период
Сортировка
От Chao Li
Тема Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
Дата
Msg-id 66A28678-BDC0-4266-9244-74320D578222@gmail.com
обсуждение исходный текст
Ответ на Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options  (Tatsuo Ishii <ishii@postgresql.org>)
Ответы Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
Список pgsql-hackers
Дерево обсуждения


On Oct 11, 2025, at 13:42, Tatsuo Ishii <ishii@postgresql.org> wrote:

Also the error is certainly user-facing,
so using elog() was quite inappropriate.  It should be ereport with an
errcode of (probably) ERRCODE_FEATURE_NOT_SUPPORTED.  Rolling your
own implementation of get_func_name() wasn't great either.

I overlooked the elog() call and "own implementation of
get_func_name()". Will fix.

Attached is a trivial patch to fix that. I am going to push it if
there's no objection.

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
<v1-0001-Use-ereport-rather-than-elog-in-WinCheckAndInitia.patch>

I just take a quick look at the patch, a tiny comment is:

```
+ char   *funcname = get_func_name(fcinfo->flinfo->fn_oid);
```

This can be a “const char *”.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/




В списке pgsql-hackers по дате отправления: