On 10/13/23 05:07, Michael Paquier wrote:
> On Fri, Oct 13, 2023 at 02:20:59AM +0200, Vik Fearing wrote:
>> On 10/10/23 05:34, Michael Paquier wrote:
>>> I am attaching a v5 that addresses the documentation bits, could you
>>> look at the business with date.c?
>>
>> Here is a v6
>
> Thanks for the new version.
>
>> which hopefully addresses all of your concerns.
>
> Mostly ;)
>
> The first thing I did was to extract the doc bits about timezone(zone,
> time) for AT TIME ZONE from v6 and applied it independently.
>
> I have then looked at the rest and it looked mostly OK to me,
> including the extra description you have added for the fifth example
> in the docs. I have tweaked a few things: the regression tests to
> make the views a bit more appealing to the eye, an indentation to not
> have koel complain and did a catalog bump. Then applied it.
Thank you, Michael君!
--
Vik Fearing