Re: GinPageIs* don't actually return a boolean

On February 12, 2016 5:15:59 PM GMT+01:00, Teodor Sigaev <teodor@sigaev.ru> wrote:
>One more option for patch:
>
>#define GinPageIsLeaf(page)    ((bool)(GinPageGetOpaque(page)->flags &
>GIN_LEAF))
>
>Seems it will work on any platform with built-in bool. But I don't know
>will it 
>work with 'typedef char bool' if high bit will be set.

Unless I am missing something major, that doesn't seem to achieve all that much. A cast to a char based bool wouldn't
normalizethis to 0 or 1. So you're still not guaranteed to be able to do somebool == anotherbool when either are set
basedon such a macro.
 

Andres

--- 
Please excuse brevity and formatting - I am writing this on my mobile phone.