Re: [REVIEW] Patch for cursor calling with named parameters

Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
> Attached is a patch with those changes. I also I removed a few of the 
> syntax error regression tests, that seemed excessive, plus some general 
> naming and comment fiddling. I'll apply this tomorrow, if it still looks 
> good to me after sleeping on it.

The code looks reasonably clean now, although I noted one comment
thinko:

> +  * bool:        trim trailing whitespace

ITYM

> +  * trim:        trim trailing whitespace

However, I'm still concerned about whether this approach gives
reasonable error messages in cases where the error would be
detected during parse analysis of the rearranged statement.
The regression test examples don't cover such cases, and I'm
too busy right now to apply the patch and check for myself.
What happens for example if a named parameter's value contains
a misspelled variable reference, or a type conflict?
        regards, tom lane