Re: Patch: Tie stats options to autovacuum in

On Oct 2, 2006, at 9:17 PM, Bruce Momjian wrote:
> Jim Nasby wrote:
>> On Oct 2, 2006, at 8:41 PM, Bruce Momjian wrote:
>>> David E. Wheeler wrote:
>>>> On Sep 28, 2006, at 16:39, Jim C. Nasby wrote:
>>>>
>>>>> +1. I was just at a client today that had run into this problem.
>>>>>
>>>>> Actually, I'm in favor of refusing to start if autovac is on  
>>>>> but the
>>>>> proper stats settings aren't. I'd rather that then people  
>>>>> ending up
>>>>> with
>>>>> bloated databases and crappy performance.
>>>>
>>>> I agree, but I figured that this was a start, at least.
>>>
>>> The problem with refusing to start is that autovacuum is sighup, so
>>> you
>>> might modify postgresql.conf and do a server restart, and then the
>>> server doesn't start.  Are people OK with that?
>>>
>>> I did apply the postgresql.conf comment addition.
>>
>> Hrm... how about if the options are incompatible on HUP we refuse to
>> pick up any new settings and complain loudly?
>
> We don't read postgresql.conf as a test and then set values.

IMHO we should... if something got botched in the config file I'd  
rather have it complain and not change anything instead of taking  
just some of the changes. This will be even more important once the  
code goes in to return to default values if something gets commented  
out in the config.
--
Jim Nasby                                            jim@nasby.net
EnterpriseDB      http://enterprisedb.com      512.569.9461 (cell)