Re: remove contrib/xml2

On Wed, Feb 3, 2010 at 8:49 AM, Alvaro Herrera
<alvherre@commandprompt.com> wrote:
> Robert Haas escribió:
>> On Mon, Feb 1, 2010 at 5:23 PM, Andrew Dunstan <andrew@dunslane.net> wrote:
>> > Robert Haas wrote:
>> >> (2) add a very, very large warning that this will crash if you do
>> >> almost anything with it.
>> >
>> > I think that's an exaggeration. Certain people are known to be using it
>> > quite successfully.
>>
>> Hmm.  Well, all I know is that the first thing I tried crashed the server.
>>
>> CREATE TABLE xpath_test (id integer NOT NULL, t xml);
>> INSERT INTO xpath_test VALUES (1, '<doc><int>1</int></doc>');
>> SELECT * FROM xpath_table('id', 't', 'xpath_test', '/doc/int', 'true')
>> as t(id int4);
>
> This trivial patch lingering on my system fixes this crasher (this is
> for the 8.3 branch).  It makes the "problem in alloc set ExprContext"
> warning show up instead.
>
> There are still lotsa other holes, but hey, this is a start ...

Interestingly M Z found he couldn't reproduce this crash on 8.3.  Can
you?  If so, +1 for applying this and backpatching it as far as make
sense.

...Robert