Re: bug: fuzzystrmatch levenshtein is wrong

On Wed, Dec 9, 2009 at 9:00 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Tue, Dec 8, 2009 at 9:45 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>> On Tue, Dec 8, 2009 at 9:08 PM, Bruce Momjian <bruce@momjian.us> wrote:
>>> Robert Haas wrote:
>>>> > patch attached.
>>>>
>>>> I cannot get this patch to apply for anything.  All 4 hunks fail, both
>>>> on HEAD and on the the pre-8.4-pgindent version of fuzzystrmatch.c.
>>>> Either I'm doing something wrong here, or there's something wrong with
>>>> this patch file.
>>>
>>> The author converted tabs to spaces --- there is not a single tab in the
>>> diff file.
>>
>> Ah.  I knew there had to be a reason.
>>
>> I'm attaching my version of this patch.  Barring objections, I am
>> going to apply this to HEAD and backpatch to 8.4, where this feature
>> (and the associated bug) were introduced.
>
> Done.  Yeah, my first commit!  However, it appears that someone needs
> to tell the pgsql-committers list that rhaas@postgresql.org is allowed
> to post there.

Uh-oh.  Is it bad that I did this between the time Tom updated the
release notes and the time Marc stamped 8.4.2?  *ducks and runs for
cover*

...Robert