Re: Patch: create or replace language

On Tue, Oct 6, 2009 at 10:24 AM, Alvaro Herrera
<alvherre@commandprompt.com> wrote:
> Andreas 'ads' Scherbaum wrote:
>>
>> Hello,
>>
>> following this old discussion:
>>
>> http://archives.postgresql.org/pgsql-patches/2008-03/msg00402.php
>>
>> i modifies the patch to use the "CREATE [OR REPLACE] LANGUAGE" syntax.
>> If the patch is ok, i will add the documentation too.
>
> Please send a context diff (however much ED IS THE STANDARD!!! TEXT
> EDITOR, we don't like its patches here).  Note that you probably missed
> updates to other functions touching the node to which you add the
> boolean.  Also, per Tom's followup,
>
>> Index: src/include/nodes/parsenodes.h
>> ===================================================================
>> RCS file: /projects/cvsroot/pgsql/src/include/nodes/parsenodes.h,v
>> retrieving revision 1.402
>> diff -r1.402 parsenodes.h
>> 1570a1571
>> >     bool            replace;                /* T => replace if already exists */
>
> this comment needs fixed.

Maybe I'm out of line to say this, but it seems to me that we should
not even be looking at newly-submitted patches at this point.

...Robert