Re: explain refactoring v4

On Fri, Jul 24, 2009 at 4:02 PM, Tom Lane<tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> OK, here it is again.  Changes are the same as the previous version,
>> but this one should apply cleanly after today's pgindent run.
>
> As I was poking through this I noticed that it makes at least one small
> change in the output format: what had been "Subquery Scan ss" will now
> be "Subquery Scan on ss", because of the unification of code that wasn't
> really entirely consistent into one subroutine ExplainScanTarget.

Wow, nice catch.

> This is not likely to matter to human readers but it might to programs.
> OTOH we presumably expect programs to migrate to using a more
> program-friendly EXPLAIN output format with 8.5.
>
> Does anyone have strong feelings about whether we need to be
> bug-compatible with the old formatting?

I kind of doubt it.  Based on previous discussions, I gather that
PGadmin et al have to be adjusted for each release anyway.  But I also
don't think it's a big deal if we make it work the way it used to.

...Robert