Re: PQinitSSL broken in some use casesf

On Fri, Feb 13, 2009 at 12:06 PM, Andrew Chernow <ac@esilo.com> wrote:
> Patch attached.
>
> One thing I noticed is the ssl_open_connections variable is ref counting
> connections when pq_initssllib is true.  But, it now only affects crypto
> library init and cleanup calls.  Point is, ref counting is only needed if
> pq_initcryptolib is true and it should be renamed to
> crypto_open_connections.  I didn't do this in the patch.  Its the same old
> name and the counter is incremented if pq_initssllib or pq_initcryptolib is
> true.  Please advise.

I'll review this in more detail when I have a chance, but it certainly
won't be committable without doc changes, and it's probably best if
you write those and include them in the patch.

...Robert