Re: oddity with ALTER ROLE/USER

On 2/22/19 4:19 PM, Tom Lane wrote:
> Joe Conway <mail@joeconway.com> writes:
>> I noticed that ALTER ROLE/USER succeeds even when called without any
>> options:
>
>> postgres=# alter user foo;
>> ALTER ROLE
>> postgres=# alter role foo;
>> ALTER ROLE
>> postgres=# alter group foo;
>> ERROR:  syntax error at or near ";"
>> LINE 1: alter group foo;
>
>> That seems odd, does nothing useful, and is inconsistent with, for
>> example, ALTER GROUP as shown above.
>
>> Proposed patch attached.
>
> If you want to make it act like alter group, why not make it act
> like alter group?  That is, the way to fix this is to change the
> grammar so that AlterOptRoleList doesn't permit an expansion with
> zero list elements.


I considered that but liked the more specific error message.

> Having said that, I can't get excited about changing this at all.
> Nobody will thank us for it, and someone might complain.


The other route is change the documentation to reflect reality I guess.

Joe

--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development