Re: pread() and pwrite()
| От | Andrew Dunstan |
|---|---|
| Тема | Re: pread() and pwrite() |
| Дата | |
| Msg-id | 5a812c25-fc4d-446b-636a-b2328709df8e@2ndQuadrant.com обсуждение исходный текст |
| Ответ на | Re: pread() and pwrite() (Jesper Pedersen <jesper.pedersen@redhat.com>) |
| Ответы |
Re: pread() and pwrite()
|
| Список | pgsql-hackers |
On 11/7/18 10:05 AM, Jesper Pedersen wrote: > Hi Tom, > > On 11/7/18 9:30 AM, Tom Lane wrote: >> I'm confused by this. Surely the pwrite-based code is writing >> exactly the >> same data as before. Do we have to conclude that valgrind is >> complaining >> about passing uninitialized data to pwrite() when it did not complain >> about exactly the same thing for write()? >> >> [ looks ... ] No, what we have to conclude is that the write-related >> suppressions in src/tools/valgrind.supp need to be replaced or augmented >> with pwrite-related ones. >> > > The attached patch fixes this for me. > > Unfortunately pwrite* doesn't work for the pwrite64(buf) line. > > Works for me. If there's no objection I will commit this. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
В списке pgsql-hackers по дате отправления: