Re: Fix wrong filename in header comment of gin_tuple.h
| От | Chao Li |
|---|---|
| Тема | Re: Fix wrong filename in header comment of gin_tuple.h |
| Дата | |
| Msg-id | 5D703C5A-4394-4B7B-929F-F7D0D992C70A@gmail.com обсуждение исходный текст |
| Ответ на | Re: Fix wrong filename in header comment of gin_tuple.h (David Rowley <dgrowleyml@gmail.com>) |
| Ответы |
Re: Fix wrong filename in header comment of gin_tuple.h
|
| Список | pgsql-hackers |
On Sep 23, 2025, at 04:02, David Rowley <dgrowleyml@gmail.com> wrote:On Mon, 22 Sept 2025 at 14:46, Chao Li <li.evan.chao@gmail.com> wrote:diff --git a/src/backend/rewrite/rowsecurity.c b/src/backend/rewrite/rowsecurity.c- * rewrite/rowsecurity.c
+ * rowsecurity.c+ *
+ * IDENTIFICATION
+ * src/backend/rewrite/rowsecurity.c
I don't what's incorrect with these as I'm not aware of the rule that
the IDENTIFICATION must exist or that the filename must be the
filename only without any of the path. Plenty of other files don't
have the identification text, so not sure why your script only picked
up on rowsecurity.c.
I see a lot of files don’t have “IDENTIFICATION”, the main problem is the filename that contains one level of parent path.
My script just scan all .c and .h files and extract one-line filename and file path from header comments. If they don’t equal to either pure filename or file path relative to repo root, then capture it. And rowsecurity.c was the only capture, so I thought the filename part (“rewrite/rowsecurity.c) was a problem. When I made the fix, I added “IDENTIFICATION” because I saw a lot of other files having it, but my script didn’t check “IDENTIFICATION”.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
HighGo Software Co., Ltd.
https://www.highgo.com/
В списке pgsql-hackers по дате отправления: