Re: [PATCH] pgpassfile connection option

Am 01.11.2016 um 15:14 schrieb Fabien COELHO:<br /><blockquote cite="mid:alpine.DEB.2.20.1611011504491.9978@lancre"
type="cite"><br/><blockquote style="color: #000000;" type="cite">Thus, when returning with an error, if
conn->pgpassfilewas set and a password was necessary, we must have tried that pgpassfile, so i got rid of the field
"dot_pgpass_used"<br /></blockquote><br /> No, you should not have done that, because it changes a feature which was to
warn<b class="moz-txt-star"><span class="moz-txt-tag">*</span>only<span class="moz-txt-tag">*</span></b> when the
passwordwas coming from file. <br /><br /> The warning is wrong, the password was typed directly, not retrieved from a
file.The "dot_pgpass_used" boolean is still required to avoid that. </blockquote><br /> I see... I was too focused on
lookingfor things to declutter, that I missed that case. I'll address that in the next revision.<br />