Re: [HACKERS] pg_sequence catalog

On 01/03/2017 03:30 PM, Peter Eisentraut wrote:
> On 1/3/17 7:23 AM, Kuntal Ghosh wrote:
>> The regression tests for hot standby check fails since it uses the
>> following statement:
>> -select min_value as sequence_min_value from hsseq;
>> which is no longer supported I guess. It should be modified as following:
>> select min_value as sequence_min_value from pg_sequences where
>> sequencename = 'hsseq';
>>
>> Attached is a patch which reflects the above changes.
>
> Fixed, thanks.
>
> I made a note to self to port this test to the TAP framework.

Hm, doesn't this change the intent of the test case? As I read the test 
it seems to make sure that we are allowed to do a read from a sequence 
relation on the slave. If so I think it should be changed to something 
like the below.

select is_called from hsseq;

Andreas