Re: [COMMITTERS] pgsql: ICU support

On 03/23/2017 11:53 PM, Tom Lane wrote:
> I wrote:
>> The buildfarm's mostly happy, but "prion" still isn't, which
>> suggests there's someplace in the new code that references an
>> already-closed relcache entry.
> Ah, scratch that, I was overthinking it.  The problem is pretty
> clear from the error message:
>
> + ERROR:  collation "en-x-icu" for encoding "SQL_ASCII" does not exist
>
> I can reproduce this with vanilla configure options if I'm running
> with --with-icu and LANG=C.  In short, this regression test does not
> work in C locale, and you need to find a way to disable it in that
> environment.



Possibly something like this:

diff --git a/src/test/regress/GNUmakefile b/src/test/regress/GNUmakefile
index a747fac..d3a68cb 100644
--- a/src/test/regress/GNUmakefile
+++ b/src/test/regress/GNUmakefile
@@ -126,8 +126,12 @@ tablespace-setup:

 REGRESS_OPTS = --dlpath=. $(EXTRA_REGRESS_OPTS)
 ifeq ($(with_icu),yes)
+ifndef NO_LOCALE
+ifneq ($(LANG),C)
 override EXTRA_TESTS := collate.icu $(EXTRA_TESTS)
 endif
+endif
+endif

 check: all tablespace-setup
    $(pg_regress_check) $(REGRESS_OPTS)
--schedule=$(srcdir)/parallel_schedule $(MAXCONNOPT) $(EXTRA_TESTS)


cheers

andrew

--
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services