Re: pgsql: Provide much better wait information in pg_stat_activity.

On 3/10/16 7:32 PM, Andres Freund wrote:
> On 2016-03-10 18:55:47 +0000, Robert Haas wrote:
>> Provide much better wait information in pg_stat_activity.
>>
>> When a process is waiting for a heavyweight lock, we will now indicate
>> the type of heavyweight lock for which it is waiting.  Also, you can
>> now see when a process is waiting for a lightweight lock - in which
>> case we will indicate the individual lock name or the tranche, as
>> appropriate - or for a buffer pin.
>
> My compiler quite validly complains:
>
> /home/andres/src/postgresql/src/backend/storage/lmgr/lmgr.c: In function ‘GetLockNameFromTagType’:
> /home/andres/src/postgresql/src/backend/storage/lmgr/lmgr.c:1018:9: warning: function may return address of local
variable[-Wreturn-local-addr] 
>   return locktypename;
>          ^
> /home/andres/src/postgresql/src/backend/storage/lmgr/lmgr.c:1007:8: note: declared here
>   char  tnbuf[32];
>         ^
> In file included from /home/andres/src/postgresql/src/backend/commands/dbcommands.c:20:0:

Needs a "static", it seems.