Doubled test for SET statements in pg_stat_statements tests

Поиск
Список
Период
Сортировка
От Sergei Kornilov
Тема Doubled test for SET statements in pg_stat_statements tests
Дата
Msg-id 5689421699428803@mail-sendbernar-production-main-46.myt.yp-c.yandex.net
обсуждение исходный текст
Ответы Re: Doubled test for SET statements in pg_stat_statements tests  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
Hello!

I noticed that the same block

-- SET statements.
-- These use two different strings, still they count as one entry.
SET work_mem = '1MB';
Set work_mem = '1MB';
SET work_mem = '2MB';
RESET work_mem;
SET enable_seqscan = off;
SET enable_seqscan = on;
RESET enable_seqscan;

is checked twice in contrib/pg_stat_statements/sql/utility.sql on lines 278-286 and 333-341. Is this on any purpose? I
thinkthe second set of tests is not needed and can be removed, as in the attached patch.
 

regards, Sergei
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: David Rowley
Дата:
Сообщение: Re: ensure, not insure
Следующее
От: Bharath Rupireddy
Дата:
Сообщение: Re: Show WAL write and fsync stats in pg_stat_io