Re: pg_stat_progress_basebackup - progress reporting forpg_basebackup, in the server side

On 2020/03/03 9:27, Kyotaro Horiguchi wrote:
> At Mon, 2 Mar 2020 17:29:30 +0900, Fujii Masao <masao.fujii@oss.nttdata.com> wrote in
>>> Attached is the updated version of the patch.
>>> The previous patch used only pgstat_progress_update_param()
>>> even when updating multiple values. Since those updates are
>>> not atomic, this can cause readers of the values to see
>>> the intermediate states. To avoid this issue, the latest patch
>>> uses pgstat_progress_update_multi_param(), instead.
>>
>> Attached the updated version of the patch.
>> Barring any objections, I plan to commit this patch.
> 
> It is working as designed and the status names are fine to me.

Thanks for the review! I pushed the patch.

> The last one comment from me.
> The newly defined symbols have inconsistent indents.

Yes, I fixed that.

Regards,


-- 
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters