Re: pg_rewind exiting with error code 1 when source and target are on the same timeline

On 12/12/15 6:08 AM, Michael Paquier wrote:
>> I committed this to master.  It's also on the 9.5 open item list, but if
>> I backport it then the tests don't pass.  Still looking.  Not sure yet
>> if this is because of code changes in pg_rewind master or test
>> infrastructure changes in master.
>
> The failure is as follows:
> source data directory must be shut down cleanly
> Failure, exiting
> not ok 1 - pg_rewind local
>
> And is caused by the fact that master checks that the source node has
> been stopped with DB_SHUTDOWNED and not DB_SHUTDOWNED_IN_RECOVERY.

It seems that the/a problem is actually that the test setup tries a
rewind using the standby as the source and the standby also as the
target.  The source should be the primary, and then it doesn't matter
whether we allow DB_SHUTDOWNED_IN_RECOVERY.  Need to check that test setup.