Re: psql completion for ids in multibyte string
От | Amit Langote |
---|---|
Тема | Re: psql completion for ids in multibyte string |
Дата | |
Msg-id | 563B224B.3020400@lab.ntt.co.jp обсуждение исходный текст |
Ответ на | psql completion for ids in multibyte string (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>) |
Ответы |
Re: psql completion for ids in multibyte string
|
Список | pgsql-hackers |
Horiguchi-san, On 2015/11/05 18:10, Kyotaro HORIGUCHI wrote: > Hello. I don't know whether this is a bug fix or improvement, Would it be 50-50? :-) ... > > During the investigation into this issue, I found a mistake in > the comment for PQmblen. It give the byte length of the character > at the point, not word. The attached patche also fixes it. > >> /* >> * returns the byte length of the word beginning s, using the >> * specified encoding. >> */ >> int >> PQmblen(const char *s, int encoding) > In the following change, - * returns the byte length of the word beginning s, using the - * specified encoding. + * returns the byte length of the character beginning s, using the specified + * encoding. Just a minor nitpick - ... character beginning *at* s ...? If so, there would be one more instance to fix. Thanks, Amit
В списке pgsql-hackers по дате отправления: