Re: pgxs/config/missing is... missing

On 10/29/15 5:31 PM, David E. Wheeler wrote:
>> >even after explicitly exporting PERL=/usr/local/bin/perl
> Hrm. I have this code in the pgTAP Makefile:
>
>      ifndef PERL
>      PERL := $(shell which perl)
>      endif
>
> Could that be causing the problem?

That doesn't help because PGXS defines PERL:

# Perl

ifneq (,)
     # quoted to protect pathname with spaces
     PERL                = ''
else
     PERL                = $(missing) perl
endif

On a system where configure could find perl, that first line is:

ifneq (/opt/local/bin/perl,)

So instead of checking ifndef, I'm thinking it should check ifeq($PERL,).

>> >I see that there is a config/missing script in source, and that Makefile.global.in references it:
>> >
>>> >>src/Makefile.global.in:missing            = $(SHELL) $(top_srcdir)/config/missing
>> >
>> >Any ideas why it's not being installed, or why the PGXS Makefile is ignoring/over-riding $PERL?
> That I surely don’t know.:-(

I'm not sure if this is the right way to go about it, but this patch at
least installs the file.
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com