Re: pltcl: sentence improvement

On 16-09-2015 10:57, Tom Lane wrote:
> Euler Taveira <euler@timbira.com.br> writes:
>> This simple patch improves a sentence. Spotted while working on translation.
>
> I concur that spelling out "#" as "number" is an improvement, but I'm
> curious which backend error you think this matches?
>
It is sort of...

utils/adt/json.c

2088         ereport(ERROR,
2089                 (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
2090                  errmsg("argument list must have even number of 
elements"),
2091                  errhint("The arguments of json_build_object() must 
consist of alternating keys and values.")));

replication/logical/logicalfuncs.c

361             ereport(ERROR,
362                     (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
363                      errmsg("array must have even number of 
elements")));

> Also, if we're going to change this message at all, I'm inclined to
> rewrite it completely, because it doesn't really follow the style
> guidelines.  How about "trigger's return list must have even number of
> elements"?
>
Works for me.


--    Euler Taveira                   Timbira - http://www.timbira.com.br/   PostgreSQL: Consultoria, Desenvolvimento,
Suporte24x7 e Treinamento